nsupdate: hygienetic clean ups

This commit is contained in:
Joel Elkins 2024-03-25 11:38:47 -05:00
parent b276075d39
commit 603d23bcf9
No known key found for this signature in database
GPG Key ID: 133589DC38921AE2

View File

@ -47,11 +47,8 @@ func (c *Container) killDnsReverse(ip string) error {
if c.TSIGName != "" {
msg.SetTsig(c.TSIGName, dns.HmacSHA256, 300, time.Now().Unix())
}
resp, _, err = cli.Exchange(msg, c.DnsServer)
if err != nil {
return err
}
return nil
_, _, err = cli.Exchange(msg, c.DnsServer)
return err
}
// This is the same code for ipv4 or ipv6 so factor it out
@ -114,10 +111,7 @@ func (c *Container) doDnsReverse(ip string, dn string, rrtype uint16) error {
msg.SetTsig(c.TSIGName, dns.HmacSHA256, 300, time.Now().Unix())
}
_, _, err = cli.Exchange(msg, c.DnsServer)
if err != nil {
return err
}
return nil
return err
}
func (c *Container) killDnsForward(name string, rrtype uint16) error {
@ -166,10 +160,8 @@ func (c *Container) doDnsForward(rr string) error {
if c.TSIGName != "" {
msg.SetTsig(c.TSIGName, dns.HmacSHA256, 300, time.Now().Unix())
}
if _, _, err = cli.Exchange(msg, c.DnsServer); err != nil {
return err
}
return nil
_, _, err = cli.Exchange(msg, c.DnsServer)
return err
}
func (c *Container) NsUpdateCommands() cmd.Set {